Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fetcher: Always open tmpfiles in repo location" #2901

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Revert "fetcher: Always open tmpfiles in repo location" #2901

merged 1 commit into from
Jun 27, 2023

Conversation

cgwalters
Copy link
Member

This reverts commit f7f6f87.

This seems to have broken flatpak, so we'll revert and then investigate.

Closes: #2900

@cgwalters cgwalters mentioned this pull request Jun 26, 2023
Open
@cgwalters cgwalters enabled auto-merge June 26, 2023 09:39
@travier
Copy link
Member

travier commented Jun 26, 2023

Looks like this is failing on something unrelated:

../src/switchroot/ostree-prepare-root.c:329:22: error: 'struct lcfs_mount_options_s' has no member named 'expected_digest'
  329 |           cfs_options.expected_digest = composefs_digest;
      |                      ^

@dustymabe
Copy link
Contributor

The CI failure:

[2023-06-26T10:19:13.292Z] --- FAIL: ext.config.root-reprovision.luks.autosave-xfs (681.51s)

[2023-06-26T10:19:13.292Z]         harness.go:1741: mach.Start() failed: machine "f92f8bb4-6451-476a-8e55-f56772f90de2" failed to start: ssh journalctl failed: time limit exceeded

Is an instance of coreos/fedora-coreos-tracker#1511

I'll restart it.

@dbnicholson
Copy link
Member

lcfs_mount_options_s

I believe this should be fixed by #2903.

@cgwalters @dbnicholson
Revert "fetcher: Always open tmpfiles in repo location"
4e61e6f 
This reverts commit f7f6f87.

This seems to have broken flatpak, so we'll revert and then
investigate.

Closes: ostreedev#2900
@dbnicholson
Copy link
Member

I rebased this to get the fix from #2903.

@cgwalters cgwalters merged commit 8deb97a into ostreedev:main Jun 27, 2023
@ElijaRock ElijaRock mentioned this pull request Jun 27, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop FUSE detection workaround for flatpak
4 participants
@cgwalters @travier @dustymabe @dbnicholson